feat: Adding Colemak #674
feat: Adding Colemak #674
Conversation
src/editor/zhuyin_layout/mod.rs
Outdated
| 13 => Self::ColemakDhAnsi, | ||
| 14 => Self::ColemakDhOrth, | ||
| 15 => Self::Workman, | ||
| 13 => Self::Colemak, | ||
| 14 => Self::ColemakDhAnsi, | ||
| 15 => Self::ColemakDhOrth, | ||
| 16 => Self::Workman, |
There was a problem hiding this comment.
You should not change the existing number. Let's add Colemak as 16th layout.
There was a problem hiding this comment.
Sounds good 👍
BTW, Workman seems to exist as a layout, so I wonder if it should be on the README's "support phonetic keyboard layout" section
|
Ouch, CI broke due to recent rustup update. I'll fix it tomorrow. |
|
Should Colemak always be below Workman? |
The numerical mapping only matters for C interface compatibility. For the enum in code we can group them together. |
|
The tests say that the return value of chewing_KBStr2Num is wrong I think? |
TLDR I tried adding Colemak as a keyboard layout.
After a recent
sudo pacman -Syu, Arch Hyprland seemed to have realized my default keyboard is colemak, which is great, except for the fact that bopomofo is now all out of whack.I found this:
https://blog.louie.lu/2024/11/15/colemak-dh-keyboard-layout-and-bopomofo-input/
so I'll see if I can do the same with just colemak.
Tests seem to be gitignored, so I'm not sure if I should write one.